Skip to content

Use GitHub Actions #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfversluis merged 10 commits into from
Jan 17, 2025
Merged

Use GitHub Actions #2091

jfversluis merged 10 commits into from
Jan 17, 2025

Conversation

@VladislavAntonyuk
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk commented Aug 3, 2024

Description of Change

Initial migration from Azure Pipeline to GitHub Actions.

Skipped NuGet publish.

Linked Issues

  • Fixes #

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@VladislavAntonyuk VladislavAntonyuk self-assigned this Aug 3, 2024
jfversluis
jfversluis reviewed Aug 9, 2024
View reviewed changes
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start!

I think we need two more things:

Both of these I think will be very similar to what Windows does. They have stages already set up and the secrets they are using are org secrets, so those should be available to us.

We "just" need to check the conditions here and make sure that they match out release procedure with creating a git tag and then using the version number from that.

@VladislavAntonyuk VladislavAntonyuk marked this pull request as ready for review August 14, 2024 19:15
@dotnet-policy-service dotnet-policy-service bot added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Sep 15, 2024
@VladislavAntonyuk VladislavAntonyuk added the needs discussion Discuss it on the next Monthly standup label Oct 1, 2024
@GeorgeLeithead
Copy link
Contributor

GeorgeLeithead commented Nov 7, 2024

Can we check to see what code coverage reports we will get? Well we be getting similar to what we get from Azure DevOps?

Copilot AI reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • .github/workflows/SignClientFileList.txt: Language not supported

@TheCodeTraveler TheCodeTraveler removed help wanted This proposal has been approved and is ready to be implemented needs discussion Discuss it on the next Monthly standup labels Dec 5, 2024
TheCodeTraveler
TheCodeTraveler reviewed Dec 8, 2024
View reviewed changes
@dotnet-policy-service dotnet-policy-service bot added the help wanted This proposal has been approved and is ready to be implemented label Jan 7, 2025
@jfversluis
Copy link
Member

jfversluis commented Jan 17, 2025

Keeping the azure-pipelines.yml around for a little bit more until we know the GitHub Actions do everything they should. Mostly releases.

I can basically only test the sign and release part by actually doing a release and when that turns out to not work, I'd rather be able to revert back to Azure Pipelines to get the release out and fix it for a next time.

@jfversluis jfversluis merged commit 1412e57 into main Jan 17, 2025
16 checks passed
@jfversluis jfversluis deleted the github-actions branch January 17, 2025 14:44
@TheCodeTraveler TheCodeTraveler removed help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days labels Jan 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TheCodeTraveler TheCodeTraveler TheCodeTraveler left review comments

Copilot code review Copilot Copilot left review comments

@jfversluis jfversluis jfversluis approved these changes

Assignees

@VladislavAntonyuk VladislavAntonyuk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VladislavAntonyuk @GeorgeLeithead @jfversluis @TheCodeTraveler